重构设备控制器

internal/app/service/device_service.go

@@ -24,7 +24,6 @@ var (
 	ErrDeviceTemplateInUse = errors.New("设备模板正在被一个或多个设备使用，无法删除")
 )
 
-// DeviceService 定义了应用层的设备服务接口，用于协调设备相关的业务逻辑。
 // DeviceService 定义了应用层的设备服务接口，用于协调设备相关的业务逻辑。
 type DeviceService interface {
 	CreateDevice(ctx context.Context, req *dto.CreateDeviceRequest) (*dto.DeviceResponse, error)
@@ -33,26 +32,12 @@ type DeviceService interface {
 	UpdateDevice(ctx context.Context, id uint32, req *dto.UpdateDeviceRequest) (*dto.DeviceResponse, error)
 	DeleteDevice(ctx context.Context, id uint32) error
 	ManualControl(ctx context.Context, id uint32, req *dto.ManualControlDeviceRequest) error
-
-	CreateAreaController(ctx context.Context, req *dto.CreateAreaControllerRequest) (*dto.AreaControllerResponse, error)
-	GetAreaController(ctx context.Context, id uint32) (*dto.AreaControllerResponse, error)
-	ListAreaControllers(ctx context.Context) ([]*dto.AreaControllerResponse, error)
-	UpdateAreaController(ctx context.Context, id uint32, req *dto.UpdateAreaControllerRequest) (*dto.AreaControllerResponse, error)
-	DeleteAreaController(ctx context.Context, id uint32) error
-
-	CreateDeviceTemplate(ctx context.Context, req *dto.CreateDeviceTemplateRequest) (*dto.DeviceTemplateResponse, error)
-	GetDeviceTemplate(ctx context.Context, id uint32) (*dto.DeviceTemplateResponse, error)
-	ListDeviceTemplates(ctx context.Context) ([]*dto.DeviceTemplateResponse, error)
-	UpdateDeviceTemplate(ctx context.Context, id uint32, req *dto.UpdateDeviceTemplateRequest) (*dto.DeviceTemplateResponse, error)
-	DeleteDeviceTemplate(ctx context.Context, id uint32) error
 }
 
 // deviceService 是 DeviceService 接口的具体实现。
 type deviceService struct {
 	ctx                   context.Context
 	deviceRepo            repository.DeviceRepository
-	areaControllerRepo    repository.AreaControllerRepository
-	deviceTemplateRepo    repository.DeviceTemplateRepository
 	deviceDomainSvc       device.DeviceOperator
 	thresholdAlarmService ThresholdAlarmService
 }
@@ -61,16 +46,12 @@ type deviceService struct {
 func NewDeviceService(
 	ctx context.Context,
 	deviceRepo repository.DeviceRepository,
-	areaControllerRepo repository.AreaControllerRepository,
-	deviceTemplateRepo repository.DeviceTemplateRepository,
 	deviceDomainSvc device.DeviceOperator,
 	thresholdAlarmService ThresholdAlarmService,
 ) DeviceService {
 	return &deviceService{
 		ctx:                   ctx,
 		deviceRepo:            deviceRepo,
-		areaControllerRepo:    areaControllerRepo,
-		deviceTemplateRepo:    deviceTemplateRepo,
 		deviceDomainSvc:       deviceDomainSvc,
 		thresholdAlarmService: thresholdAlarmService,
 	}
@@ -213,213 +194,3 @@ func (s *deviceService) ManualControl(ctx context.Context, id uint32, req *dto.M
 		return s.deviceDomainSvc.Switch(serviceCtx, dev, action)
 	}
 }
-
-// --- Area Controllers ---
-
-func (s *deviceService) CreateAreaController(ctx context.Context, req *dto.CreateAreaControllerRequest) (*dto.AreaControllerResponse, error) {
-	serviceCtx := logs.AddFuncName(ctx, s.ctx, "CreateAreaController")
-	propertiesJSON, err := json.Marshal(req.Properties)
-	if err != nil {
-		return nil, err
-	}
-
-	ac := &models.AreaController{
-		Name:       req.Name,
-		NetworkID:  req.NetworkID,
-		Location:   req.Location,
-		Properties: propertiesJSON,
-	}
-
-	if err := ac.SelfCheck(); err != nil {
-		return nil, err
-	}
-
-	if err := s.areaControllerRepo.Create(serviceCtx, ac); err != nil {
-		return nil, err
-	}
-
-	return dto.NewAreaControllerResponse(ac)
-}
-
-func (s *deviceService) GetAreaController(ctx context.Context, id uint32) (*dto.AreaControllerResponse, error) {
-	serviceCtx := logs.AddFuncName(ctx, s.ctx, "GetAreaController")
-	ac, err := s.areaControllerRepo.FindByID(serviceCtx, id)
-	if err != nil {
-		return nil, err
-	}
-	return dto.NewAreaControllerResponse(ac)
-}
-
-func (s *deviceService) ListAreaControllers(ctx context.Context) ([]*dto.AreaControllerResponse, error) {
-	serviceCtx := logs.AddFuncName(ctx, s.ctx, "ListAreaControllers")
-	acs, err := s.areaControllerRepo.ListAll(serviceCtx)
-	if err != nil {
-		return nil, err
-	}
-	return dto.NewListAreaControllerResponse(acs)
-}
-
-func (s *deviceService) UpdateAreaController(ctx context.Context, id uint32, req *dto.UpdateAreaControllerRequest) (*dto.AreaControllerResponse, error) {
-	serviceCtx := logs.AddFuncName(ctx, s.ctx, "UpdateAreaController")
-	existingAC, err := s.areaControllerRepo.FindByID(serviceCtx, id)
-	if err != nil {
-		return nil, err
-	}
-
-	propertiesJSON, err := json.Marshal(req.Properties)
-	if err != nil {
-		return nil, err
-	}
-
-	existingAC.Name = req.Name
-	existingAC.NetworkID = req.NetworkID
-	existingAC.Location = req.Location
-	existingAC.Properties = propertiesJSON
-
-	if err := existingAC.SelfCheck(); err != nil {
-		return nil, err
-	}
-
-	if err := s.areaControllerRepo.Update(serviceCtx, existingAC); err != nil {
-		return nil, err
-	}
-
-	return dto.NewAreaControllerResponse(existingAC)
-}
-
-func (s *deviceService) DeleteAreaController(ctx context.Context, id uint32) error {
-	serviceCtx := logs.AddFuncName(ctx, s.ctx, "DeleteAreaController")
-
-	// 1. 检查是否存在
-	_, err := s.areaControllerRepo.FindByID(serviceCtx, id)
-	if err != nil {
-		return err // 如果未找到，gorm会返回 ErrRecordNotFound
-	}
-
-	// 2. 检查是否被使用（业务逻辑）
-	inUse, err := s.areaControllerRepo.IsAreaControllerUsedByTasks(serviceCtx, id, []models.TaskType{models.TaskTypeAreaCollectorThresholdCheck})
-	if err != nil {
-		return err // 返回数据库检查错误
-	}
-	if inUse {
-		return ErrAreaControllerInUse // 返回业务错误
-	}
-
-	// TODO 这个应该用事务处理
-	err = s.thresholdAlarmService.DeleteAreaThresholdAlarmByAreaControllerID(serviceCtx, id)
-	if err != nil {
-		return fmt.Errorf("删除区域阈值告警失败: %w", err)
-	}
-
-	// 3. 执行删除
-	return s.areaControllerRepo.Delete(serviceCtx, id)
-}
-
-// --- Device Templates ---
-
-func (s *deviceService) CreateDeviceTemplate(ctx context.Context, req *dto.CreateDeviceTemplateRequest) (*dto.DeviceTemplateResponse, error) {
-	serviceCtx := logs.AddFuncName(ctx, s.ctx, "CreateDeviceTemplate")
-	commandsJSON, err := json.Marshal(req.Commands)
-	if err != nil {
-		return nil, err
-	}
-
-	valuesJSON, err := json.Marshal(req.Values)
-	if err != nil {
-		return nil, err
-	}
-
-	deviceTemplate := &models.DeviceTemplate{
-		Name:         req.Name,
-		Manufacturer: req.Manufacturer,
-		Description:  req.Description,
-		Category:     req.Category,
-		Commands:     commandsJSON,
-		Values:       valuesJSON,
-	}
-
-	if err := deviceTemplate.SelfCheck(); err != nil {
-		return nil, err
-	}
-
-	if err := s.deviceTemplateRepo.Create(serviceCtx, deviceTemplate); err != nil {
-		return nil, err
-	}
-
-	return dto.NewDeviceTemplateResponse(deviceTemplate)
-}
-
-func (s *deviceService) GetDeviceTemplate(ctx context.Context, id uint32) (*dto.DeviceTemplateResponse, error) {
-	serviceCtx := logs.AddFuncName(ctx, s.ctx, "GetDeviceTemplate")
-	deviceTemplate, err := s.deviceTemplateRepo.FindByID(serviceCtx, id)
-	if err != nil {
-		return nil, err
-	}
-	return dto.NewDeviceTemplateResponse(deviceTemplate)
-}
-
-func (s *deviceService) ListDeviceTemplates(ctx context.Context) ([]*dto.DeviceTemplateResponse, error) {
-	serviceCtx := logs.AddFuncName(ctx, s.ctx, "ListDeviceTemplates")
-	deviceTemplates, err := s.deviceTemplateRepo.ListAll(serviceCtx)
-	if err != nil {
-		return nil, err
-	}
-	return dto.NewListDeviceTemplateResponse(deviceTemplates)
-}
-
-func (s *deviceService) UpdateDeviceTemplate(ctx context.Context, id uint32, req *dto.UpdateDeviceTemplateRequest) (*dto.DeviceTemplateResponse, error) {
-	serviceCtx := logs.AddFuncName(ctx, s.ctx, "UpdateDeviceTemplate")
-	existingDeviceTemplate, err := s.deviceTemplateRepo.FindByID(serviceCtx, id)
-	if err != nil {
-		return nil, err
-	}
-
-	commandsJSON, err := json.Marshal(req.Commands)
-	if err != nil {
-		return nil, err
-	}
-
-	valuesJSON, err := json.Marshal(req.Values)
-	if err != nil {
-		return nil, err
-	}
-
-	existingDeviceTemplate.Name = req.Name
-	existingDeviceTemplate.Manufacturer = req.Manufacturer
-	existingDeviceTemplate.Description = req.Description
-	existingDeviceTemplate.Category = req.Category
-	existingDeviceTemplate.Commands = commandsJSON
-	existingDeviceTemplate.Values = valuesJSON
-
-	if err := existingDeviceTemplate.SelfCheck(); err != nil {
-		return nil, err
-	}
-
-	if err := s.deviceTemplateRepo.Update(serviceCtx, existingDeviceTemplate); err != nil {
-		return nil, err
-	}
-
-	return dto.NewDeviceTemplateResponse(existingDeviceTemplate)
-}
-
-func (s *deviceService) DeleteDeviceTemplate(ctx context.Context, id uint32) error {
-	serviceCtx := logs.AddFuncName(ctx, s.ctx, "DeleteDeviceTemplate")
-
-	// 1. 检查是否存在
-	_, err := s.deviceTemplateRepo.FindByID(serviceCtx, id)
-	if err != nil {
-		return err
-	}
-
-	// 2. 检查是否被使用（业务逻辑）
-	inUse, err := s.deviceTemplateRepo.IsInUse(serviceCtx, id)
-	if err != nil {
-		return err
-	}
-	if inUse {
-		return ErrDeviceTemplateInUse // 返回业务错误
-	}
-
-	// 3. 执行删除
-	return s.deviceTemplateRepo.Delete(serviceCtx, id)
-}